Skip to content

Rework diffusion models#191

Open
henrikjacobsenfys wants to merge 20 commits into
developfrom
delta-lorentz
Open

Rework diffusion models#191
henrikjacobsenfys wants to merge 20 commits into
developfrom
delta-lorentz

Conversation

@henrikjacobsenfys
Copy link
Copy Markdown
Member

@henrikjacobsenfys henrikjacobsenfys commented May 22, 2026 •
edited
Loading

The changes are described here: #190

I'm missing some tests, but the code is more or less how I want it to be, so a review would be nice

@henrikjacobsenfys henrikjacobsenfys added [scope] enhancement Adds/improves features (major.MINOR.patch) [priority] medium Normal/default priority labels May 22, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 22, 2026 •
edited
Loading

Codecov Report

❌ Patch coverage is 80.85106% with 72 lines in your changes missing coverage. Please review.
✅ Project coverage is 96.54%. Comparing base (fff0285) to head (0f724ff).

Files with missing lines Patch % Lines
...mics/sample_model/diffusion_model/delta_lorentz.py 76.69% 42 Missing and 13 partials ⚠️
...mple_model/diffusion_model/diffusion_model_base.py 83.75% 11 Missing and 2 partials ⚠️
src/easydynamics/analysis/fit_binding.py 0.00% 2 Missing and 2 partials ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop     #191      +/-   ##
===========================================
- Coverage    98.42%   96.54%   -1.89%     
===========================================
  Files           50       51       +1     
  Lines         3175     3501     +326     
  Branches       576      643      +67     
===========================================
+ Hits          3125     3380     +255     
- Misses          26       81      +55     
- Partials        24       40      +16
Flag Coverage Δ
integration 44.98% <34.84%> (-1.19%) ⬇️
unittests 96.45% <80.05%> (-1.97%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

This was linked to issues May 22, 2026
Make sure diffusion models generate the correct dependent parameters #76
Open
Consider if DiffusionModel should store Q internally #77
Open
@henrikjacobsenfys henrikjacobsenfys marked this pull request as ready for review May 26, 2026 07:42
@henrikjacobsenfys henrikjacobsenfys added [priority] high Should be prioritized soon and removed [priority] medium Normal/default priority labels May 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

[priority] high Should be prioritized soon [scope] enhancement Adds/improves features (major.MINOR.patch)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Consider if DiffusionModel should store Q internally Make sure diffusion models generate the correct dependent parameters

1 participant

@henrikjacobsenfys